Experimental Physics and
Industrial Control System

Benjamin Franksen <[email protected]> · Fri, 21 Sep 2007 15:36:21 +0200

On Friday 21 September 2007 12:30, Benjamin Franksen wrote:
> I have not produced a fix for this problem. I guess you (Eric) know
> better how to approach this.

Well, my current, very crude, solution is to replace all (seven) 
clnt_destroy calls by

    if (pvxiPort->rpcClient) {
        clnt_destroy(pvxiPort->rpcClient);
        pvxiPort->rpcClient = 0;
    } else {
        if(pasynUser) asynPrint(pasynUser,ASYN_TRACE_ERROR,
            "%s internal error: RPC handle already 
destroyed\n",pvxiPort->portName);
    }

In fact I can see the above 'internal error' messages appearing when I run 
our test setup.

There is yet another problem: the error checking after calls to clnt_call si 
wrong. The code is

    if(stat!=RPC_SUCCESS || errno!=0) {
    	/* error handling */
	}

which leads to pseudo errors; errno should be checked only if the return 
value is abnormal. It should be just

    if(stat!=RPC_SUCCESS) {
    	/* error handling */
	}

Also, the error message should not output the numerical value of errno, but 
the number converted to a string (via strerror) as is done in all other 
parts of the file.

Cheers
Ben

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System