Experimental Physics and
Industrial Control System

Ben Franksen <[email protected]> · Fri, 25 Apr 2008 20:01:22 +0200

On Freitag, 25. April 2008, Andrew Johnson wrote:
> Jeff Hill wrote:
> > 2) Standardize throughout base on a new flag controlling the removal of
> > high overhead consistency checking code and set this flag by default in
> > production (optimized) builds.
>
> If you're thinking about adding some expensive consistency checking that
> will significantly affect performance when enabled then I fully agree to
> having them disabled in production builds.  However I don't particularly
> like the idea of having them enabled whenever the OPT flag is off, since
> it then becomes hard to separate out bugs that are caused by a compiler
> when optimization is turned on; I'd much prefer a separate switch which
> can be set on a per-subsystem or even per-compilation unit basis,
> separate from the compiler optimization switch.

Yes, definitely. Make it a separate global flag, easily (un-)settable in 
CONFIG_SITE*. Beside your argument about optimization induced bugs, it is 
important that users can test per application how great the performance 
gain really is and decide for themselves whether it is worth the loss in 
debugability.

Cheers
Ben

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System