EPICS RE: Possible bug in areaDetector/ADSupport/supportApp/nexusSrc/Makefile?

1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 <2017> 2018 2019 2020 2021 2022 2023 2024	Index	1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 <2017> 2018 2019 2020 2021 2022 2023 2024
<== Date ==>		<== Thread ==>

These are now all fixed and pushed to master branch on Github.

From: Mark Rivers
Sent: Monday, November 20, 2017 8:50 AM
To: Jörn Dreyer; [email protected]
Subject: Re: Possible bug in areaDetector/ADSupport/supportApp/nexusSrc/Makefile?

Hi Jörn,

Thanks for finding that. I just did a search of all the Makefiles in areaDetector, looking for lines with the string USR_INCLUDES and without the string -I. There are actually a number of errors like the one you found. I will fix these today.

corvette:~/devel/areaDetector>find . -name Makefile -exec grep -H USR_INCLUDES {} \; | grep -v "\-I"

./ADPluginEdge/edgeApp/edgeSrc/Makefile:USR_INCLUDES += $(OPENCV_INCLUDE)

./ADAndor/andorApp/src/Makefile: USR_INCLUDES += $(XML2_INCLUDE)

./ADADSC/adscApp/src/Makefile:# detcon_state.h. USR_INCLUDES should include the directories containing

./ADURL/urlApp/src/Makefile: USR_INCLUDES += $(GRAPHICSMAGICK_INCLUDE)

./ADSupport/supportApp/hdf5Src/Makefile: USR_INCLUDES += $(SZIP_INCLUDE)

./ADSupport/supportApp/hdf5Src/Makefile: USR_INCLUDES += $(ZLIB_INCLUDE)

./ADSupport/supportApp/hdf5Src/Makefile: USR_INCLUDES += $(BLOSC_INCLUDE)

./ADSupport/supportApp/nexusSrc/Makefile: USR_INCLUDES += $(HDF5_INCLUDE)

./ADSupport/supportApp/nexusSrc/Makefile: USR_INCLUDES += $(SZIP_INCLUDE)

./ADSupport/supportApp/nexusSrc/Makefile: USR_INCLUDES += $(ZLIB_INCLUDE)

./ADSupport/supportApp/hdf5_hlSrc/Makefile: USR_INCLUDES += $(SZIP_INCLUDE)

./ADSupport/supportApp/hdf5_hlSrc/Makefile: USR_INCLUDES += $(ZLIB_INCLUDE)

./ADSupport/supportApp/bloscSrc/Makefile: USR_INCLUDES += $(ZLIB_INCLUDE)

./ADCore/ADApp/pluginSrc/Makefile: USR_INCLUDES += $(GRAPHICSMAGICK_INCLUDE)

./ADCore/ADApp/pluginTests/Makefile:# USR_INCLUDES += $(HDF5_INCLUDE)

Mark

From: [email protected] <[email protected]> on behalf of Jörn Dreyer <[email protected]>
Sent: Monday, November 20, 2017 7:09 AM
To: [email protected]
Subject: Possible bug in areaDetector/ADSupport/supportApp/nexusSrc/Makefile?

Hi,

on an Debian based Linux system I had some trouble to compile the areaDetector
module. In CONFIG_SITE.local one can define path variables for various
external components. In contrast to most Linux distributions I know, Debian
installs HDF5 in a sub path under /usr/include/hdf5 depending on the version
of HDF5 that is installed (serial, openmpi, openmpich...) So one has to set up
the correct path in CONFIG_SITE.local. By doing that at using the internal
version of Nexus, I discovered a problem in the Makefile. In this Makefile the
path's for HDF5, SZIP and ZLIB are added to USR_INCLUDES as

USR_INCLUDES += $(HDF5_INCLUDES)

While in all other Makefiles this is included as

USR_INCLUDES += -I$(HDF5_INCLUDES)

The compilation then fails with hdf5.h not found. After adding the -I I was
able to compile areaDetector on this system.

Regards,

Jörn

Subject:	RE: Possible bug in areaDetector/ADSupport/supportApp/nexusSrc/Makefile?
From:	Mark Rivers <[email protected]>
To:	Jörn Dreyer <[email protected]>, "[email protected]" <[email protected]>
Date:	Mon, 20 Nov 2017 18:57:36 +0000

Experimental Physics and Industrial Control System