Argonne National Laboratory

Experimental Physics and
Industrial Control System

1994  1995  1996  1997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  <2017 Index 1994  1995  1996  1997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  <2017
<== Date ==> <== Thread ==>

Subject: Re: log client in base 3.15
From: Andrew Johnson <anj@aps.anl.gov>
To: <tech-talk@aps.anl.gov>
Date: Mon, 18 Sep 2017 17:31:03 -0500
Hi Freddie,

On 09/18/2017 10:25 AM, freddie.akeroyd@stfc.ac.uk wrote:
> 
> I'd noticed some of our IOC log messages were appearing in our caPutLog
> log since we moved to base 3.15.5  Having looked at the code, it seems
> that in 3.15 logClientCreate() calls errlogAddListener() whereas in 3.14
> this was not the case and errlogAddListener() was called from
> iocLogClientInit()   I moved the errlogAddListener() call back into
> iocLogClientInit() and that seemed to fix my immediate problem, but that
> may not be the best solution as I guess the change was made to make it
> clear/easier to add additional errlog clients?

That change was committed back in 2014, prior to the first official
Base-3.15.1 release:

https://github.com/epics-base/epics-base/commit/ac2ff29abb4c5856ac5fcedeb684e9397a107f30

> Author: Ralph Lange <ralph.lange@gmx.de>  2014-11-18 08:23:14
> 
>     libCom/log: make iocLog client unregister its listener from errlog on shutdown

I can see that the previous version didn't have any code for
unregistering the listener at all, and my guess is that Ralph moved the
registration code so that listener registration and removal happens as
part of the IOC startup and shutdown (allowing it to be run multiple
times while starting up and shutting down IOCs as part of the Unit Test
improvements).

We could probably add a control to disable the errlogAddListener(), but
we already have the iocLogDisable setting, and two controls might be a
bit confusing.

Ralph, can you comment?

- Andrew

-- 
Arguing for surveillance because you have nothing to hide is no
different than making the claim, "I don't care about freedom of
speech because I have nothing to say." -- Edward Snowdon

References:
log client in base 3.15 freddie.akeroyd

Navigate by Date:
Prev: Re: Action Button in Display Builder Maren Purves
Next: Re: Notification of Archiver Appliance interruptions Michael Davidsaver
Index: 1994  1995  1996  1997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  <2017
Navigate by Thread:
Prev: log client in base 3.15 freddie.akeroyd
Next: dbVerify removed from EPICS 3.16 michael.abbott
Index: 1994  1995  1996  1997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  <2017
ANJ, 19 Sep 2017 Valid HTML 4.01! · Home · News · About · Base · Modules · Extensions · Distributions · Download ·
· EPICS V4 · IRMIS · Talk · Bugs · Documents · Links · Licensing ·