EPICS RE: Mythen writeFloat64()

Experimental Physics and Industrial Control System

1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 <2017> 2018 2019 2020 2021 2022 2023 2024	Index	1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 <2017> 2018 2019 2020 2021 2022 2023 2024
<== Date ==>		<== Thread ==>

Subject:	RE: Mythen writeFloat64()
From:	Mark Rivers <[email protected]>
To:	'Iain Marcuson' <[email protected]>, "[email protected] >> EPICS Tech Talk" <[email protected]>
Date:	Mon, 1 May 2017 20:25:37 +0000

Hi Iain,

Thanks for spotting that, it was an error.  I have fixed it and pushed to Github.

Mark


-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Iain Marcuson
Sent: Monday, May 01, 2017 3:16 PM
To: [email protected] >> EPICS Tech Talk
Subject: Mythen writeFloat64()

I have been looking at the Mythen driver and have spotted some code that seems quite odd.  Line 1213 contains
if (function < NUM_SD_PARAMS)
but comparing this with the examples for writeOctet and writeInt32, along with the comments, suggest that this line should be
if (function < FIRST_SD_PARAM)

Am I missing some subtlety, or is this an error?

Iain.

References:: Mythen writeFloat64() Iain Marcuson

Navigate by Date:: Prev: Mythen writeFloat64() Iain Marcuson; Next: RE: EpicsQT and Archiver Appliance Andraz Pozar; Index: 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 <2017> 2018 2019 2020 2021 2022 2023 2024
Navigate by Thread:: Prev: Mythen writeFloat64() Iain Marcuson; Next: Question about autosave ? lzf neu; Index: 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 <2017> 2018 2019 2020 2021 2022 2023 2024