Experimental Physics and
Industrial Control System

Mark Rivers <[email protected]> · Tue, 12 Jul 2016 12:56:59 +0000

Hi Hinko,

Your change looks correct to me, I don't know where the factor of 2 was coming from.  I added that code back in January 2012, but I probably only tested with small values of binning (e.g. 1, 2, 3, 4).  I will make the change and test on our Andor iDus 401 camera.

Mark

________________________________________
From: [email protected] [[email protected]] on behalf of Hinxx [[email protected]]
Sent: Tuesday, July 12, 2016 2:52 AM
To: [email protected]
Subject: AndorCCD binning

Hi Mark,

Binning handling in AD andorCCD support does not allow to produce full
vertical binning (width x 1 image). Looking at the code I noticed that
some magic with trying to figure out the minY might be the problem. Also
when trying to come up with the binY values Andor SDK rejects some valid
binning values because other parameters to SetImage() are invalid.

unsigned int WINAPI SetImage(int hbin, int vbin, int hstart, int hend,
int vstart, int vend)

For example Andor Luca with 1004x1002 detector and binY set to 1002
yields this call to the SetImage():

SetImage(1,1002,1,1004,-1001,0)

Of course it results in error from Andor SDK (-1001 is not valid minY).

Probably same applies to horizontal binning..


After changing some of the lines of the andorCCD.cpp I can successfully
set binY to 1002 and get 1004 x 1 image:

diff --git a/andorApp/src/andorCCD.cpp b/andorApp/src/andorCCD.cpp
index ff09114..2ff92e0 100755
--- a/andorApp/src/andorCCD.cpp
+++ b/andorApp/src/andorCCD.cpp
@@ -1060,12 +1060,12 @@
    getIntegerParam(ADSizeY, &sizeY);
    getIntegerParam(ADMaxSizeX, &maxSizeX);
    getIntegerParam(ADMaxSizeY, &maxSizeY);
-  if (minX > (maxSizeX - 2*binX)) {
-    minX = maxSizeX - 2*binX;
+  if (minX > (maxSizeX - binX)) {
+    minX = maxSizeX - binX;
      setIntegerParam(ADMinX, minX);
    }
-  if (minY > (maxSizeY - 2*binY)) {
-    minY = maxSizeY - 2*binY;
+  if (minY > (maxSizeY - binY)) {
+    minY = maxSizeY - binY;
      setIntegerParam(ADMinY, minY);
    }
    if ((minX + sizeX) > maxSizeX) {

The call to SetImage() is now:

SetImage(1,1002,1,1004,1,1002)


This change might break other Andor detectors, here at ESS and with CEA
partner we can test Andor Newton and Andor Luca.


Thanks,
Hinko




Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System