Experimental Physics and
Industrial Control System

Andrew Johnson <[email protected]> · Thu, 8 Oct 2015 14:21:57 -0500

On 10/08/2015 01:40 PM, Michael Davidsaver wrote:
> Actually, it looks to me like the call to errlogRemoveListeners could
> be moved to the beginning of logClientDestroy, before the client
> thread is stopped.

Be careful with that, the order that the two epicsAtExit() routines will
be run isn't obvious, and errlogRemoveListeners() doesn't always lock
the pvtData.listenerLock. The IOC is also not the only executable that
uses the errlog subsystem, although it's less common for other
applications to start a logClient.

I'm not saying we can't make that change, but it should be approached
with caution and tests which start (and hence shut down) the two
subsystems in both orders.

- Andrew

-- 
Light thinks it travels faster than anything but it is wrong.
No matter how fast light travels, it finds the darkness has
always got there first, and is waiting for it.
    -- Terry Pratchett, Reaper Man

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System