Experimental Physics and
Industrial Control System

<[email protected]> · Thu, 20 Nov 2014 11:48:29 +0000

I've just noticed that caget incorrectly prints values of type DBR_CHAR, or to be precise, the behaviour of caget depends on whether the compiler is operating with signed or unsigned characters.  The patch below fixes this:

--- a/src/catools/tool_lib.c	2013-01-18 14:00:04.809032934 +0000
+++ b/src/catools/tool_lib.c	2014-11-20 11:39:53.181733735 +0000
@@ -106,7 +106,6 @@
 {
 #define STR 500
     static char str[STR];
-    char ch;
     void *val_ptr;
     unsigned base_type;
     dbr_long_t val_long;
@@ -150,8 +149,7 @@
         }
         break;
     case DBR_CHAR:
-        ch = ((dbr_char_t*) val_ptr)[index];
-        sprintf(str, "%d", ch);
+        sprintf(str, "%d", ((dbr_char_t*) val_ptr)[index]);
         break;
     case DBR_INT:
         sprint_long(str, ((dbr_int_t*) val_ptr)[index], outTypeI);



-- 
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. 
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
 






Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System