Experimental Physics and
Industrial Control System

Benjamin Franksen <[email protected]> · Fri, 16 Dec 2011 13:04:25 +0100

On Wednesday, December 07, 2011, Josh Stein wrote:
> Hello Benjamin and community,
>
>    I am attempting to build version 2.1.3 of the sequencer on a windows
> machine. I have the MinGW tools installed along with a windows version
> of re2c. I have also already successfully built EPICS base, the example
> app and an older version of the sequencer (2.0.14) in the past.
>
> When executing the build from the 2.1.3 top level directory, the
> following warnings and errors are shown and the make is stopped:
>
>
>
> ../../../include/pv.h:75:37: warning: inline function 'pvSystem*
> pvSystem::getSystem()' declared as  dllimport: attribute ignored
> [-Wattributes]
> ../../../include/pv.h:77:35: error: function 'pvStat pvSystem::attach()'
> definition is marked dllimport
> ../../../include/pv.h:78:35: error: function 'pvStat pvSystem::flush()'
> definition is marked dllimport

I would like to pose this question to the community, especially the C++
experts.

These are the relevant lines:

class pvSystem {

public:
    epicsShareFunc pvSystem( int debug = 0 );
    epicsShareFunc virtual ~pvSystem();

    epicsShareFunc inline pvSystem *getSystem() { return this; }

    epicsShareFunc virtual pvStat attach() { return pvStatOK; }
    epicsShareFunc virtual pvStat flush() { return pvStatOK; }
...
}

The code in the src/pv subsystem in the sequencer uses 'epicsShareFunc' for
C++ class methods in many places (also in the method implementations). While
it seems it has worked so far, I wonder if epicsShareFunc' is necessary here
or even intended. I looked at some EPICS base header and cpp files and found
'epicsShareFunc' is not used for C++ class methods.

So, can I just remove 'epicsShareFunc' qualifiers on class methods?

At least on my win32-x86 VM this worked fine (build & tests).

Cheers
Ben

________________________________

Helmholtz-Zentrum Berlin für Materialien und Energie GmbH

Mitglied der Hermann von Helmholtz-Gemeinschaft Deutscher Forschungszentren e.V.

Aufsichtsrat: Vorsitzender Prof. Dr. Dr. h.c. mult. Joachim Treusch, stv. Vorsitzende Dr. Beatrix Vierkorn-Rudolph
Geschäftsführer: Prof. Dr. Anke Rita Kaysser-Pyzalla, Dr. Ulrich Breuer

Sitz Berlin, AG Charlottenburg, 89 HRB 5583

Postadresse:
Hahn-Meitner-Platz 1
D-14109 Berlin

http://www.helmholtz-berlin.de

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System