Experimental Physics and
Industrial Control System

Eric Norum <[email protected]> · Tue, 22 Dec 2009 09:46:48 -0800

Hmm... 
I guess that's o.k.
It kind of feels like abuse of the preprocessor -- I know that epicsStdioRedirect.h is already somewhat guilty of this but this seems one step even farther.
Your call.

On Dec 22, 2009, at 9:28 AM, Andrew Johnson wrote:

> On Tuesday 22 December 2009 11:01:50 Eric Norum wrote:
>> The fix is simple.  Andrew, please change this on both the trunk and the
>> branch.
>> 
>> Change the 'puts' on line 264 of src/db/dbTest.c to a printf:
>>            if (epicsStrGlobMatch(pname, pmask)) printf("%s\n", pname);
> 
> Following the principle of least surprise (since that's how I broke this in 
> the first place), how about we add this to libCom/osi/epicsStdioRedirect.h 
> instead?
> 
> #ifdef puts
> #  undef puts
> #endif /* puts */
> #define puts(str) epicsStdoutPrintf("%s\n", str)
> 
> - Andrew
> -- 
> The best FOSS code is written to be read by other humans -- Harald Welte
> 

-- 
Eric Norum
[email protected]

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System