Experimental Physics and
Industrial Control System

Till Straumann <[email protected]> · Fri, 21 Aug 2009 11:37:09 -0500

Browsing epics-3.14.10 I came across a typical
lazy-init which is obviously not thread-safe:

from libCom/osi/os/default/osdInterrupt.c:

static epicsMutexId globalLock=0;
static int firstTime = 1;

epicsShareFunc int epicsShareAPI epicsInterruptLock()
{
   if(firstTime) {
       globalLock = epicsMutexMustCreate();
       firstTime = 0;
   }
   epicsMutexMustLock(globalLock);
   return(0);
}

I see this kind of code quite often (and must admit
that I have committed this sort of error myself...)

FWIW
-- Till

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System