Experimental Physics and
Industrial Control System

Noboru Yamamoto <[email protected]> · Tue, 13 Nov 2001 12:03:09 +0900

Hi,

 devMbboDirectCamac.c in dev/camacDev directory uses val field of its
record structure
when writing data to CAMAC module as show below:

        cfsa(pcio->f, pcio->ext, &(pmbbodirect->val), &q);

The VAL field of mbboDIrect record is defined as:

field(VAL,DBF_USHORT)

while the function cfsa() has a prototype:

void  cfsa   (int f, int ext, int *dat, int *q);

The convert() function in mbboDirectRecord.c apply bit shift to the VAL
field and is called
just before writeValue() function is called in a process routine.

static void convert(pmbboDirect)
        struct mbboDirectRecord  *pmbboDirect;
{
       /* convert val to rval */
        pmbboDirect->rval = (unsigned long)(pmbboDirect->val);
        if(pmbboDirect->shft>0)
             pmbboDirect->rval <<= pmbboDirect->shft;

        return;
}

So, I think a call of cfsa  in devMbboDirectCamac.c could be:

        cfsa(pcio->f, pcio->ext, &(pmbbodirect->rval), &q);.

Or is there any good reason to use current code?

Thank you for your comments/opinions in advance,

Noboru Yamamoto
KEKB control group
KEK, JAPAN

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System