Experimental Physics and
Industrial Control System

Benjamin Franksen at BESSY reported a bug in callback.c.
Note that the routine ProcessCallback is never used
in base. The bug will be fixed in the next 3.13 release.
The description is attached.

Marty Kraimer

--- Begin Message ---

Subject:	EPICS: Error in db/callback.c
From:	Benjamin Franksen <[email protected]>
To:	Marty Kraimer <[email protected]>
Date:	Wed, 25 Jun 1997 17:07:34 +0200

Hi Marty,

it's a bit strange to me that none has noticed yet a very obvious error
in callback.c. It is even printed in the documentation (Appl. Dev.
Guide, pg. 153). The function ProcessCallback dereferences a NULL
pointer:

static void ProcessCallback(CALLBACK *pCallback)
{
   dbCommon *pRec = NULL;
   struct rset *prset = (struct rset *)pRec->rset);
                                       ^^^^^^^^^^
   ...
}

I propose it to be changed to what (I think) it was meant to be:

static void ProcessCallback(CALLBACK *pCallback)
{
    dbCommon    *pRec;

    callbackGetUser(pRec, pCallback);
    dbScanLock(pRec);
    (*((struct rset *)pRec->rset)->process)(pRec);
    dbScanUnlock(pRec);
}

	Ben
-- 
The Notorious Neb Nesknarf
// snail: BESSY II, Rudower Chaussee 5, D-12489 Berlin, Germany
// email: [email protected]
// phone/fax: +49(30)6392-4865 / 6392-4859

--- End Message ---

Navigate by Date:

Prev: Re: NI-1014 help needed Andrew Johnson

Next: MEDM Print Ron Chestnut

Index: 1994  1995  1996  <1997>  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  2019  2020  2021  2022  2023  2024 

Navigate by Thread:

Prev: Tcl & Epics Steve Hunt

Next: MEDM Print Ron Chestnut

Index: 1994  1995  1996  <1997>  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  2019  2020  2021  2022  2023  2024