EPICS Controls Argonne National Laboratory

Experimental Physics and
Industrial Control System

1994  1995  <19961997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  2019  2020  2021  2022  2023  2024  Index 1994  1995  <19961997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  2019  2020  2021  2022  2023  2024 
<== Date ==> <== Thread ==>

Subject: Re: bug(?) in dbStaticLib.c
From: Marty Kraimer <[email protected]>
To: [email protected]
Date: Wed, 15 May 1996 08:23:31 -0500
MURANAKA Masaki wrote:
> 
> Hello,
> 
> I think new dbStaticLib.c (in R3.13.0alpha3) has problem about
> dealing parm string. It's a serious problem in GPIB devices.
> putParamString() in dbStatic/dbStaticLib.c shuld look '@' up.
> 
> Following code is unofficial patch.
>                                                 from monaka
> --------------------------------------------------------------
> static long putParmString(char **pparm,char *pstring)
> {
>     size_t      size;
>     char *pstr, *end;
> 
>     if(!(end = strchr(pstring,'@'))) return (S_dbLib_badField);

I think this should be

   if(!pstring || !(pstring = strchr(pstring,'@'))) return (0);

     
>     pstr = end + 1;
>     size = strlen(pstr) + 1;
>     if(size>=MAX_STRING_SIZE) return(S_dbLib_badLink);
>     if(*pparm && (*pparm != pNullString)) free((void *)(*pparm));
>     *pparm = dbCalloc(size, sizeof(char *));
>     strcpy(*pparm,pstr);
>     return(0);
> }

Except for above comment the above is a good solution.
Reason for change is that the @<parm value> is optional.
Yes this is a serious bug. If fact the parm field of all bus types
would not work.

I am going to set up a WWW page release notes for alpha3 bugs.
It will appear next to the alph3 release notes.

We REALLY REALLY want people to start using R3.13.0.alph3!!!.
We will pay VERY serious attention to all bugs you find.


MURANAKA thank you very much for discovering and solving this problem.


Marty Kraimer


References:
bug(?) in dbStaticLib.c MURANAKA Masaki

Navigate by Date:
Prev: Re: install EPICS on HP faild (sockio.h) Johnny Tang
Next: SCO/Open Desktop Port of EPICS Stefan Hippler
Index: 1994  1995  <19961997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  2019  2020  2021  2022  2023  2024 
Navigate by Thread:
Prev: bug(?) in dbStaticLib.c MURANAKA Masaki
Next: [Fwd: CapFast floating lic] Jeff Hill
Index: 1994  1995  <19961997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  2019  2020  2021  2022  2023  2024 
ANJ, 10 Aug 2010 Valid HTML 4.01! · Home · News · About · Base · Modules · Extensions · Distributions · Download ·
· Search · EPICS V4 · IRMIS · Talk · Bugs · Documents · Links · Licensing ·