EPICS Controls Argonne National Laboratory

Experimental Physics and
Industrial Control System

2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  <20192020  2021  2022  2023  2024  Index 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  <20192020  2021  2022  2023  2024 
<== Date ==> <== Thread ==>

Subject: Re: Need changes to makeTesfile.pl for Rtems5
From: "Johnson, Andrew N. via Core-talk" <[email protected]>
To: "[email protected]" <[email protected]>
Date: Fri, 18 Jan 2019 22:16:37 +0000
Hello Heinz,

On 1/18/19 12:54 PM, Heinz P. Junkes via Core-talk wrote:
Unfortunately I have to change something for the new RTEMS when generating the testfiles in /src/tool/makeTestfile.pl.

What is the most elegant way to do this? I can't tell if I'm doing Rtems4 or Rtems5 in the script.
When I just added the arguments  -append --console=/dev/com1  to the qemu-system-i386 command line they didn't affect the tests running on RTEMS-4.10.2 at all, so I don't see a problem with just adding that independent of the RTEMS version. I haven't checked RTEMS-4.9 although I don't see why that would behave differently (but please enlighten me if my assumptions there are wrong).

Does RTEMS-5 really need the double-quotes around its kernel command line? I left them out for my tests but I'm not running RTEMS-5 so I don't know for sure. I would prefer to just use $exe instead of $exec in the die message if it does. Can you try this patch instead of yours against both RTEMS versions:

diff --git a/src/tools/makeTestfile.pl b/src/tools/makeTestfile.pl
index 7d29876..173f84a 100644
--- a/src/tools/makeTestfile.pl
+++ b/src/tools/makeTestfile.pl
@@ -38,7 +38,10 @@ if( $TA =~ /^win32-x86/ && $HA !~ /^win/ ) {
 
 # Run pc386 test harness w/ QEMU
 } elsif( $TA =~ /^RTEMS-pc386-qemu$/ ) {
-  $exec = "qemu-system-i386 -m 64 -no-reboot -serial stdio -display none -net nic,model=ne2k_pci -net user,restrict=yes -kernel $exe";
+  my $args = '-m 64 -no-reboot -serial stdio -display none '
+           . '-net nic,model=ne2k_pci -net user,restrict=yes '
+           . '-append --console=/dev/com1'
+  $exec = "qemu-system-i386 $args -kernel $exe";
 
 # Explicitly fail for other RTEMS targets
 } elsif( $TA =~ /^RTEMS-/ ) {
@@ -59,7 +62,8 @@ use Cwd 'abs_path';
 \$ENV{HARNESS_ACTIVE} = 1 if scalar \@ARGV && shift eq '-tap';
 \$ENV{TOP} = abs_path(\$ENV{TOP}) if exists \$ENV{TOP};
 
-system('$exec') == 0 or die "Can't run $exec: \$!\\n";
+system('$exec') == 0
+    or die "Can't run $exe: \$!\\n";
 EOF
 
 close $OUT or die "Can't close $target: $!\n";

- Andrew
-- 
Arguing for surveillance because you have nothing to hide is no
different than making the claim, "I don't care about freedom of
speech because I have nothing to say." -- Edward Snowdon

References:
Need changes to makeTesfile.pl for Rtems5 Heinz P. Junkes via Core-talk

Navigate by Date:
Prev: Need changes to makeTesfile.pl for Rtems5 Heinz P. Junkes via Core-talk
Next: Strange change in behavior from 7.0.1 to 7.0.2 Mark Rivers via Core-talk
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  <20192020  2021  2022  2023  2024 
Navigate by Thread:
Prev: Need changes to makeTesfile.pl for Rtems5 Heinz P. Junkes via Core-talk
Next: Strange change in behavior from 7.0.1 to 7.0.2 Mark Rivers via Core-talk
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  <20192020  2021  2022  2023  2024 
ANJ, 23 Jan 2019 Valid HTML 4.01! · Home · News · About · Base · Modules · Extensions · Distributions · Download ·
· Search · EPICS V4 · IRMIS · Talk · Bugs · Documents · Links · Licensing ·