Argonne National Laboratory

Experimental Physics and
Industrial Control System

2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  <2017 Index 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  <2017
<== Date ==> <== Thread ==>

Subject: Re: IOC error message on camonitor disconnect
From: Andrew Johnson <anj@aps.anl.gov>
To: <core-talk@aps.anl.gov>
Date: Mon, 31 Jul 2017 11:28:54 -0500
Hi Michael,

Thanks for working on this.

On 07/31/2017 09:41 AM, Michael Davidsaver wrote:
> With this in mind, I found two issues:
> 
> * calls to send_err() in camessage() were missing SEND_LOCK().
> * cas_send_bs_msg() could set "send.stk=0" outside of SEND_LOCK().
> 
> Freddie reports that these changes avoid the crash, but he still sees
> the "Missaligned protocol rejected" message.
> 
> I'm planning to commit these to the 3.14 branch.
> 
> https://github.com/epics-base/epics-base/compare/R3.15.5...mdavidsaver:rsrv-locking

Question about your change to caserverio.c: Presumably it is possible
for cas_send_bs_msg() to be called with both lock_needed and
pclient->disconnect true? Won't this also need

    if ( lock_needed ) {
        SEND_UNLOCK(pclient);
    }

in the "if ( pclient->disconnect ) {" path before returning?

- Andrew

-- 
Arguing for surveillance because you have nothing to hide is no
different than making the claim, "I don't care about freedom of
speech because I have nothing to say." -- Edward Snowdon

Replies:
Re: IOC error message on camonitor disconnect Michael Davidsaver
References:
Re: IOC error message on camonitor disconnect Michael Davidsaver
Re: IOC error message on camonitor disconnect Michael Davidsaver

Navigate by Date:
Prev: areaDetector developers meeting @ ITER Mark Rivers
Next: Re: IOC error message on camonitor disconnect Michael Davidsaver
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  <2017
Navigate by Thread:
Prev: Re: IOC error message on camonitor disconnect Michael Davidsaver
Next: Re: IOC error message on camonitor disconnect Michael Davidsaver
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  <2017
ANJ, 31 Jul 2017 Valid HTML 4.01! · Home · News · About · Base · Modules · Extensions · Distributions · Download ·
· EPICS V4 · IRMIS · Talk · Bugs · Documents · Links · Licensing ·