Argonne National Laboratory

Experimental Physics and
Industrial Control System

2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  <2017 Index 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  <2017
<== Date ==> <== Thread ==>

Subject: Re: Fwd: bugfix of PCAS library
From: Wang Xiaoqiang <xiaoqiang.wang@psi.ch>
To: Andrew Johnson <anj@aps.anl.gov>, EPICS core-talk <core-talk@aps.anl.gov>
Date: Wed, 10 May 2017 12:00:16 +0200
I agree this is a quick fix by duplicating code and refactoring is needed.

One idea I had was to add an API virtual function "getValueSizeElements" to gdd, in analog to "getDataSizeElements". But that would make gdd interface depend on gddAppTable, which might be a bad practice.

On 05/10/2017 12:57 AM, Andrew Johnson wrote:
Unless anyone objects I propose to cherry-pick this commit onto the 3.14
branch. As Xiaoqiang says in the commit message this change has already
been implemented in the monitorResponse methods; this adds the same code
to the readResponse and readNotifyResponse methods, and while I don't
claim to understand the PCAS code in detail I can see that the same
change is likely to be needed there for the PCAS to support dynamic
arrays properly.

Thanks Xiaoqiang!

- Andrew

-------- Forwarded Message --------
Subject: bugfix of PCAS library
Date: Fri, 5 May 2017 13:21:50 +0200
From: Wang Xiaoqiang <xiaoqiang.wang@psi.ch>
To: tech-talk <tech-talk@aps.anl.gov>


Hi,

The problem was discovered using a PCASpy server application.
https://github.com/paulscherrerinstitute/pcaspy/issues/43

A short summary is that the pcas library calculate the wrong size if a
container type gdd is returned by a server application, in a read action
with zero requested count.

The proposed change has been verified to fix the issue.
https://github.com/xiaoqiangwang/epics-base/commit/f1367b28c6e620f2b4abb276812df854c47e3a48

Best
Xiaoqiang


Replies:
Re: Fwd: bugfix of PCAS library Andrew Johnson
References:
Fwd: bugfix of PCAS library Andrew Johnson

Navigate by Date:
Prev: Re: Fwd: bugfix of PCAS library Bruce Hill
Next: Re: Fwd: bugfix of PCAS library Andrew Johnson
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  <2017
Navigate by Thread:
Prev: Re: Fwd: bugfix of PCAS library Bruce Hill
Next: Re: Fwd: bugfix of PCAS library Andrew Johnson
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  <2017
ANJ, 10 May 2017 Valid HTML 4.01! · Home · News · About · Base · Modules · Extensions · Distributions · Download ·
· EPICS V4 · IRMIS · Talk · Bugs · Documents · Links · Licensing ·