Experimental Physics and
Industrial Control System

Andrew Johnson <[email protected]> · Fri, 3 Apr 2015 17:22:24 -0500

On 04/03/2015 05:04 PM, Michael Davidsaver wrote:
> Then again having one, tested, implementation might let us chase out
> things like dbContextReadNotifyCacheAllocator.
> 
> https://bugs.launchpad.net/epics-base/+bug/1440186

This does need to be looked at and fixed on the 3.14 branch, then merged
forward to the others.

Looking briefly at the patch I'm not too keen on adding magic numbers to
released code, although they were probably useful for development and
debugging purposes. There also looked to be a number of casts in the
patch which I didn't have time to understand, including an offset by ±1
in places. I would prefer to avoid adding casts, especially in C++ code.

- Andrew

-- 
Light thinks it travels faster than anything but it is wrong.
No matter how fast light travels, it finds the darkness has
always got there first, and is waiting for it.
    -- Terry Pratchett, Reaper Man

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System