Experimental Physics and
Industrial Control System

Benjamin Franksen <[email protected]> · Wed, 4 Mar 2015 20:36:48 +0100

Hi Andrew

On Tuesday 03 March 2015 17:01:00 Andrew Johnson wrote:
> On 02/28/2015 12:14 PM, Benjamin Franksen wrote:
> > 3) fix_-re_defined-echo-in-configure_os_config_common_rtems.patch
> >
> > We found that the RTEMS build system (we use 4.9) has its own
> > definition of ECHO, so we re-define ECHO after including them.
>
> Applied, but used the newer value of ECHO which is more portable.

Yes, fine.

> > 4)
> > fix_-release_cfg_config-and-_rules-should-be-in-reverse-order.patch
> >
> > RULES and CONFIG files from the cfg subdir of other modules must be
> > included in the opposite order in which they appear in the
> > configure/RELEASE file. This is because the RELEASE file lists them
> > in reverse dependency order. This is the correct order when
> > creating search paths (because in that case earlier entries win
> > over later ones), but not when including make file snippets
> > (because in that case later entries win over earlier ones).
>
> You reversed the include order for the <top>/cfg/CONFIG* and
> <top>/cfg/RULES* files, but not for the <top>/configure/RULES_BUILD
> files. Wouldn't that make sense too?

I think I simply forgot this. Probably because the sequencer is the only
module we use that has its own RULES_BUILD and the definitions in there
do not overlap with those in base. But in general we can't rely on that,
so: yes, definitely.

> > 5) extend-the-cfg-mechanism-to-rules_top.patch
> >
> > Finally one patch which adds a feature and is not a bug fix: in
> > addition to adding RULES in a support module, this allows users to
> > add TOP_RULES. In case it is not evident why this is useful, please
> > shout and I'll explain.
>
> I'd be interested in seeing your use-case, but I do think this is
> probably worthwhile too.

We have two separate use cases.

The first is for distributing build results to the production area. We
have a special tool named "rsync-dist" that distributes non-
destructively and allows some kind of versioning on the remote
(production) host. Since the tool requires many options to work and also
outputs a lot of text that users normally don't want to see, I have
added a few simple "TOP-only" make targets that call the tool with the
appropriate options and filters its output. This could have been done
with a wrapper script, too, but unlike shell or Perl, make does not
introduce an extra layer of quoting, which makes it a bit easier to
write such a wrapper.

The second use case is for generating cross-referenced documentation. In
this case the extra top rules trigger calls to another tool written by
another colleague that scans the source tree and generates a small tree
of cross-referenced html files, for instance about which db file is
loaded by which IOC. This doc generation step is done automatically
after everything else has been built.

Cheers
Ben
--
"Make it so they have to reboot after every typo." ― Scott Adams

________________________________

Helmholtz-Zentrum Berlin für Materialien und Energie GmbH

Mitglied der Hermann von Helmholtz-Gemeinschaft Deutscher Forschungszentren e.V.

Aufsichtsrat: Vorsitzender Prof. Dr. Dr. h.c. mult. Joachim Treusch, stv. Vorsitzende Dr. Beatrix Vierkorn-Rudolph
Geschäftsführung: Prof. Dr. Anke Rita Kaysser-Pyzalla, Thomas Frederking

Sitz Berlin, AG Charlottenburg, 89 HRB 5583

Postadresse:
Hahn-Meitner-Platz 1
D-14109 Berlin

http://www.helmholtz-berlin.de

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System