Experimental Physics and
Industrial Control System

Andrew Johnson <[email protected]> · Tue, 3 Mar 2015 17:01:00 -0600

Hi Ben,

Thanks for these patches, comments below:

On 02/28/2015 12:14 PM, Benjamin Franksen wrote:
> 1) fixed-release_perl_module_dirs.patch
> 
> RELEASE_PERL_MODULE_DIRS is generated wrongly: <TOP>_LIB is not the same
> as <TOP>/lib.

Applied.

> 2) fix_-improve-misleading-_installing-____-messages-in-rules_db.patch
> 
> This just fixes some "Creating..." messages.

Applied.

> 3) fix_-re_defined-echo-in-configure_os_config_common_rtems.patch
> 
> We found that the RTEMS build system (we use 4.9) has its own definition
> of ECHO, so we re-define ECHO after including them.

Applied, but used the newer value of ECHO which is more portable.

> 4) fix_-release_cfg_config-and-_rules-should-be-in-reverse-order.patch
> 
> RULES and CONFIG files from the cfg subdir of other modules must be
> included in the opposite order in which they appear in the
> configure/RELEASE file. This is because the RELEASE file lists them in
> reverse dependency order. This is the correct order when creating search
> paths (because in that case earlier entries win over later ones), but
> not when including make file snippets (because in that case later
> entries win over earlier ones).

You reversed the include order for the <top>/cfg/CONFIG* and
<top>/cfg/RULES* files, but not for the <top>/configure/RULES_BUILD
files. Wouldn't that make sense too?

> 5) extend-the-cfg-mechanism-to-rules_top.patch
> 
> Finally one patch which adds a feature and is not a bug fix: in addition
> to adding RULES in a support module, this allows users to add TOP_RULES.
> In case it is not evident why this is useful, please shout and I'll
> explain.

I'd be interested in seeing your use-case, but I do think this is
probably worthwhile too.

- Andrew

-- 
Doctorow's Law: Anytime someone puts a lock on something you own,
    against your wishes, and doesn't give you the key, they're
    not doing it for your benefit.

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System