Experimental Physics and
Industrial Control System

mdavidsaver <[email protected]> · Thu, 10 Jul 2014 22:14:06 -0000

> In dbUnitTest.c shouldn't the Type arguments to OP use the
>     epics{Int,UInt,Float}<n> names? If not I suspect there
>     should at least be a couple more 'unsigned' keywords in
>     there.

Before I can answer this question I think you will need to educate me a bit about argument type promotion in vararg functions.  Does va_arg() have knowledge of this?  Will va_arg(X,short) actually return an 'int'?

My thinking at the time was that since these rules are a bit obscure, that it would be better to explicitly document a mapping of variable type to DBF_*.  You will find such a mapping in a comment in dbUnitTest.h.  I'm not too attached to this approach though, the point is that a put operation should be one line.

Just to throw out another idea.  I have considered using printf style syntax just to get a compile time check.  eg. testdbPutField("pvname", DBF_LONG, "%d", 0) where exactly "%d" must be used for DBF_LONG.  As a side effect this would work well for DBF_STRING.

-- 
https://code.launchpad.net/~epics-core/epics-base/ioc-shutdown2/+merge/224213
Your team EPICS Core Developers is subscribed to branch lp:epics-base.

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System