Experimental Physics and
Industrial Control System

Andrew Johnson <[email protected]> · Mon, 02 Jul 2012 18:45:36 -0000

Hi Ralph,

Thanks.

Sorry, a couple more issues, then I think I'm done:

The name 'epicsShowThreadInfo' implies this routine is part of the epicsShow subsystem.  The original name 'showThreadInfo' was static and thus only used internally to the posix implementation, but if you're making it visible I think it needs to match the other epicsThread... names.  Maybe name it epicsThreadShowPrivate(), which matches the Win32 implementation (although there the routine is static).

If you don't intend that routine to be called by user code the declaration for it doesn't have to appear in any header files either, it could just appear in the posix/osdThread.c file where it's used.  I would also prefer that it take an epicsThreadId argument instead of the epicsThreadOSD* pointer; that should remain for internal use only (epicsThread.h has a typedef making the two identical).

- Andrew

-- 
https://code.launchpad.net/~ralph-lange/epics-base/thread-hooks/+merge/112806
Your team EPICS Core Developers is requested to review the proposed merge of lp:~ralph-lange/epics-base/thread-hooks into lp:epics-base.

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System