Experimental Physics and
Industrial Control System

Andrew Johnson <[email protected]> · Tue, 06 Sep 2011 15:26:20 -0000

Hi Jeff,

On 2011-09-02 you wrote:
> Committed a fix, but I am unable to build for this version of Solaris here
>  so we may need to iterate.

/opt/SUNWspro/bin/CC -c  -D_POSIX_C_SOURCE=199506L  -D_XOPEN_SOURCE=500            
-DUNIX  -DSOLARIS=10 -mt  -D__EXTENSIONS__   -O   +w           -xcode=pic32  -
I. -I../O.Common -I. -I../../../src/libCom/osi/compiler/solStudio -
I../../../src/libCom/osi/compiler/default -I. -
I../../../src/libCom/osi/os/solaris -I../../../src/libCom/osi/os/posix -
I../../../src/libCom/osi/os/default -I.. -I../../../src/libCom/as -
I../../../src/libCom/bucketLib -I../../../src/libCom/calc -
I../../../src/libCom/cvtFast -I../../../src/libCom/cppStd -
I../../../src/libCom/cxxTemplates -I../../../src/libCom/dbmf -
I../../../src/libCom/ellLib -I../../../src/libCom/env -
I../../../src/libCom/error -I../../../src/libCom/fdmgr -
I../../../src/libCom/flex -I../../../src/libCom/freeList -
I../../../src/libCom/gpHash -I../../../src/libCom/iocsh -
I../../../src/libCom/log -I../../../src/libCom/macLib -
I../../../src/libCom/misc -I../../../src/libCom/osi -I../../../src/libCom/ring 
-I../../../src/libCom/taskwd -I../../../src/libCom/timer -
I../../../src/libCom/tsDefs -I../../../src/libCom/yacc -
I../../../include/compiler/solStudio -I../../../include/os/solaris -
I../../../include        ../../../src/libCom/osi/os/posix/epicsAtomicOSD.cpp 
"../../../src/libCom/osi/os/solaris/epicsAtomicOSD.h", line 67: Error: Formal 
argument 1 of type volatile unsigned long* in call to 
atomic_cas_ulong(volatile unsigned long*, unsigned long, unsigned long) is 
being passed unsigned*.
"../../../src/libCom/osi/os/solaris/epicsAtomicOSD.h", line 97: Error: Formal 
argument 1 of type volatile unsigned long* in call to 
atomic_inc_ulong_nv(volatile unsigned long*) is being passed unsigned*.
"../../../src/libCom/osi/os/solaris/epicsAtomicOSD.h", line 116: Error: Formal 
argument 1 of type volatile unsigned long* in call to 
atomic_dec_ulong_nv(volatile unsigned long*) is being passed unsigned*.
"../../../src/libCom/osi/os/solaris/epicsAtomicOSD.h", line 136: Error: Formal 
argument 1 of type volatile unsigned long* in call to 
atomic_add_long_nv(volatile unsigned long*, long) is being passed unsigned*.
"../../../src/libCom/osi/os/solaris/epicsAtomicOSD.h", line 147: Error: Formal 
argument 1 of type volatile unsigned long* in call to 
atomic_add_long_nv(volatile unsigned long*, long) is being passed unsigned*.
5 Error(s) detected.

> The _nv versions are necessary because, in our interface, we return the
>  result of the atomic operation to the user.

Not a problem, I was just making sure that was a conscious decision of yours, 
although I thought it probably was; the comment said "on some platforms" and 
you added the epicsAtomicPerformTest.c code so we can easily measure that.

- Andrew
-- 
Optimization is the process of taking something that works and
replacing it with something that almost works, but costs less.
-- Roger Needham

https://code.launchpad.net/~epics-core/epics-base/rebased-atomics/+merge/73915
Your team EPICS Core Developers is subscribed to branch lp:epics-base.

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System