Experimental Physics and
Industrial Control System

Here's what I noticed:

 * All EPICS Base environment variables start with 'EPICS_' - please use that prefix on the name of the env var that defines the DBD.
 * Lines 104/106 of the code seem to do the same thing?!
 * I was confused by seeing all these "ezca..." strings in code that (luckily) does not use ezca. But they obviously are only used internally.
 * The error message in case <pv>.RTYP is not found should be a bit more explanatory. If you run the tool against a CAS based server (e.g. excas), it says "Record "fred" not found". Well, the PV "fred" does indeed exist, it's just not an EPICS record.
 * Please consistently use single or double quotes around channel names in printed messages.

-- 
https://code.launchpad.net/~ronaldo-mercado/epics-base/capr/+merge/26037
Your team EPICS Core Developers is requested to review the proposed merge of lp:~ronaldo-mercado/epics-base/capr into lp:epics-base.

References:

[Merge] lp:~ronaldo-mercado/epics-base/capr into lp:epics-base Ronaldo Mercado

Navigate by Date:

Prev: Re: [Merge] lp:~khkim/epics-base/fix-timestamp into lp:epics-base Ralph Lange

Next: Re: [Merge] lp:~ronaldo-mercado/epics-base/capr into lp:epics-base Andrew Johnson

Index: 2002  2003  2004  2005  2006  2007  2008  2009  <2010>  2011  2012  2013  2014  2015  2016  2017  2018  2019  2020  2021  2022  2023  2024 

Navigate by Thread:

Prev: Re: [Merge] lp:~ronaldo-mercado/epics-base/capr into lp:epics-base Andrew Johnson

Next: Re: [Merge] lp:~ronaldo-mercado/epics-base/capr into lp:epics-base Andrew Johnson

Index: 2002  2003  2004  2005  2006  2007  2008  2009  <2010>  2011  2012  2013  2014  2015  2016  2017  2018  2019  2020  2021  2022  2023  2024