Experimental Physics and
Industrial Control System

Ralph Lange <[email protected]> · Wed, 31 Mar 2010 11:46:40 -0400

Note that you can easily add your comments to an existing EPICS bug by
including
   <bugnumber>@bugs.launchpad.net
in the recipient list. (551909 for this one.)
The email has to be GPG-signed and match your public key that has been
uploaded to the Launchpad site.
Full details at: https://help.launchpad.net/Bugs/EmailInterface

Ralph

Eric Norum wrote:
> I like this change a little better.  It leaves the buffer null-terminated if at all possible.
> Mark, can you check this on the system that was causing problem and see if it fixes things?
>
>
>
> diff -u macCore.c.orig macCore.c
> --- macCore.c.orig	2010-03-31 08:31:20.000000000 -0700
> +++ macCore.c	2010-03-31 08:33:51.000000000 -0700
> @@ -697,6 +697,10 @@
>          printf( "trans-> entry = %p, level = %d, maxlen = %u, discard = %s, "
>          "rawval = %s\n", entry, level, (unsigned int)(valend - *value), discard ? "T" : "F", *rawval );
>  
> +    /* Don't write past end of buffer */
> +    if (valend == *value) { entry->error = TRUE; return; }
> +    if (--valend == *value) { *valend = '\0'; entry->error = TRUE; return; }
> +
>      /* initially not in quotes */
>      quote = 0;
>
>
>   

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System