> Jeff: should I commit that (double buffer) patch to the APS
repository for 3.14 and the trunk?
> Or send it to you first?
Yes please, go ahead with a commit. I
will try to have a very quick look after you are done. No doubt that you have
been careful about freeing anything that gets allocated.
> The CA data garble issue was solved by applying the patch from
Peter Denison. Do you want me to
> commit that, too?
Here are some of the issues that I seem to recall should be looked at.
O I think that there were a few spots in
the source that were missed by them that might not be observed as failures in
an IOC but might still come up (maybe only in the portable server).
O It would be nice to consolidate the
hardware architecture specific stuff into one place in the source code.
O We would like to configure the software
based on the endian type macros, and set these macros from the configure files
based on the hardware architecture type so we don’t end up with an
endless proliferation of ifdef test cases, but perhaps this has been attended
to already.
O maybe others - I should have a closer
look
I had concluded that this work could be
postponed until we get serious about another patch release, but perhaps my procrastination
is causing some grief in terms of duplicated work. It seems that more folks are
using ARM processors than I initially expected.
Jeff
From: Eric Norum
[mailto:[email protected]]
Sent: Thursday, August 24, 2006
10:26 AM
To: Ralph Lange
Cc: Jeff Hill; 'EPICS Core Talk';
'Ralf Hartmann'
Subject: Re:
osiSockDiscoverBroadcastAddresses(): pointer not word-aligned?
Great detective work!
I did a quick google check and it seems that SIOCGIFCONF is not a very
well defined operation. Your plan to copy to a properly aligned local buffer
sounds good to me.
On Aug 24, 2006, at 11:07 AM, Ralph Lange wrote:
OK - here are our latest findings:
First - the Bottom line: The RTEMS network code does not work as
expected. Calling socket_ioctl() with SIOCGIFCONF does return also AF_LINK
structures, not just AF_INET interfaces, as the linux man page says.
We are suggesting to keep the double buffer: memcpy()ing whatever is
coming up into a local buffer which is word-aligned, and handing a pointer to
that copy down in subsequent socket_ioctl() calls. This doesn't use much space
and time and should be safe - no matter what is coming up in the ifreq array.
osiSockDiscoverBroadcastAddresses() isn't called much anyway.
Jeff: should I commit that patch to the APS repository for 3.14 and the
trunk? Or send it to you first?
The CA data garble issue was solved by applying the patch from Peter
Denison. Do you want me to commit that, too?
Thanks again to both of you for your valuable help!!
Argonne National Laboratory