Experimental Physics and
Industrial Control System

Ralph Lange <[email protected]> · Sun, 06 Nov 2005 23:55:21 +0100

Commenting out an unused argument in this place is perfectly legal C/C++

code. This actually is done in a lot of places within base. I'm not sure

exactly why this 3.2.3 gcc is barking at this line - it definitely

shouldn't.

Background: When I was simply throwing out unused arguments to get by

compiler warnings, Jeff convinced me to follow his style of just

commenting them out to help someone reading the code understand what the

arguments are - even when they're not used, which happens quite often

within C++ code.

I don't know how to handle this, as this looks rather like a compiler

bug than bad code to me .... Jeff, what do you think?

Ralph

Ernest L. Williams Jr. wrote:

Hi Ralph,

How is it going?

The latest changes you made to support HP-UX for the R3-14-2_branch
broke the build on:
-- OS: Red Hat Enterprise Linux AS release 3 (Taroon Update 5)
-- Kernel: 2.4.21-20.EL
-- GCC: gcc version 3.2.3 20030502 (Red Hat Linux 3.2.3-53)

=====================================================================
/base/src/ca/cac.cpp between versions 1.180.2.29 and 1.180.2.30
=====================================================================
Ralph, why do have comments inside of the function to make HP-UX happy?
For example, between versions 1.180.2.29 and 1.180.2.30 of cac.cpp?

====== snippet from cac.cpp ============================================
bool cac::echoRespAction (
   callbackManager & mgr, tcpiiu & iiu,
   const epicsTime & /* current */, const caHdrLargeArray &, void * )
=========================================================================

Here is the error I get any ideas?:
=====================================================================
/usr/bin/g++ -c   -D_POSIX_C_SOURCE=199506L -D_POSIX_THREADS
-D_XOPEN_SOURCE=500        -D_X86_  -DUNIX  -D_BSD_SOURCE -Dlinux
-D_REENTRANT -ansi  -O3  -Wall          -g -fPIC -I. -I..
-I../../../include/os/Linux -I../../../include         ../cac.cpp
../cac.cpp: In member function `bool
cac::echoRespAction(callbackManager&,
  tcpiiu&, const epicsTime&, const caHdrLargeArray&, void*)':
../cac.cpp:754: no matching function for call to
`tcpiiu::probeResponseNotify(
  epicsGuard<epicsMutex>&)'
../virtualCircuit.h:376: candidates are: void
  tcpiiu::probeResponseNotify(epicsGuard<epicsMutex>&, const
epicsTime&)
make[3]: *** [cac.o] Error 1
make[3]: Leaving directory
`/ade/epics/supTop/base/R3-14-2_branch-Oct-28-2005/src/ca/O.linux-x86'
make[2]: *** [install.linux-x86] Error 2
make[2]: Leaving directory
`/ade/epics/supTop/base/R3-14-2_branch-Oct-28-2005/src/ca'
make[1]: *** [ca.install] Error 2
make[1]: Leaving directory
`/ade/epics/supTop/base/R3-14-2_branch-Oct-28-2005/src'
make: *** [src.install] Error 2
[williams@ics-srv02 R3.14.8]$ cd src/ca
[williams@ics-srv02 ca]$ vi cac.cpp
[williams@ics-srv02 ca]
====================================================================

The build is perfect on:
OS: Red Hat Enterprise Linux WS release 4 (Nahant Update 1)
Kernel: Linux dragon 2.6.9-22.EL
GCC: gcc version 3.4.3 20050227 (Red Hat 3.4.3-22.1)

The build is also good on the 64-bit linux platform.

Thanks,
Ernest L. Williams Jr.
SNS Control Systems Group
ORNL

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System